Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): Empty workflow list state & improvements #6666

Merged
merged 1 commit into from
Oct 9, 2024
Merged

feat(dashboard): Empty workflow list state & improvements #6666

merged 1 commit into from
Oct 9, 2024

Conversation

desiprisg
Copy link
Contributor

@desiprisg desiprisg commented Oct 9, 2024 •
edited
Loading

What changed? Why was the change needed?

  • Empty workflow list state
  • min height on dashboard layout children
  • Hide table footer if not necessary
  • Overflow now happens outside table as discussed privately with @SokratisVidros
  • Updated tanstack query to v5 as it was on v4

Screenshots

image

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@desiprisg desiprisg self-assigned this Oct 9, 2024
@linear Linear
Copy link

linear bot commented Oct 9, 2024

NV-4460 Workflows List Empty State

@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 1bfb135
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6706a6fdde18bf0008e7688b
😎 Deploy Preview https://deploy-preview-6666--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@desiprisg desiprisg force-pushed the nv-4460-workflows-list-empty-state branch from fed2f74 to 92d5188 Compare October 9, 2024 15:33
LetItRock
LetItRock approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

apps/dashboard/src/components/workflow-cloud.tsx Outdated Show resolved Hide resolved
apps/dashboard/src/components/workflow-cloud.tsx Outdated Show resolved Hide resolved
apps/dashboard/src/components/workflow-list.tsx Outdated Show resolved Hide resolved
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 9, 2024 •
edited
Loading

Open in Stackblitz

novu

pnpm add https://pkg.pr.new/novuhq/novu@6666

@novu/client

pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@6666

@novu/framework

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6666

@novu/headless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@6666

@novu/js

pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@6666

@novu/nest

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nest@6666

@novu/node

pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@6666

@novu/notification-center

pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@6666

@novu/providers

pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@6666

@novu/react

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@6666

@novu/react-native

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@6666

@novu/shared

pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@6666

@novu/stateless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/stateless@6666

commit: 1bfb135

@desiprisg desiprisg force-pushed the nv-4460-workflows-list-empty-state branch from 92d5188 to 1bfb135 Compare October 9, 2024 15:53
@LetItRock LetItRock merged commit 9260b6d into next Oct 9, 2024
40 checks passed
@LetItRock LetItRock deleted the nv-4460-workflows-list-empty-state branch October 9, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifont rifont rifont left review comments

@LetItRock LetItRock LetItRock approved these changes

@SokratisVidros SokratisVidros Awaiting requested review from SokratisVidros

Assignees

@desiprisg desiprisg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desiprisg @LetItRock @rifont